Draft: Add support for Vision #34
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Includes mapping for OpenAI and Anthropic.
|
@sixlive what do you think of this approach? |
|
Would resolve #32 |
|
I think this is a solid start, I'll sleep on it and might pick this up tomorrow. This is definitely high on my list of things I want to enable. |
|
I've actually rolled almost exactly this logic out in a custom OpenAI provider from my app internally and it works great. |
|
I've got it it working with Prism Server for OpenAI but it will need some work for Anthropic. This isn't too far off how I was going to approach things. I'm going to run with this a bit. Its going to be my focus going into next week. |
|
Closing in favor of #42 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for Vision to OpenAI and Anthropic.