Skip to content

Add types for modbus-ng interface#477

Draft
mx990 wants to merge 2 commits into
eclipse-4diac:developfrom
mx990:modbus-ngTypes
Draft

Add types for modbus-ng interface#477
mx990 wants to merge 2 commits into
eclipse-4diac:developfrom
mx990:modbus-ngTypes

Conversation

@mx990

@mx990 mx990 commented Sep 13, 2024

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Sep 13, 2024

Copy link
Copy Markdown

Test Results

   111 files  +    4     111 suites  +4   48s ⏱️ -2s
29 177 tests +1 817  29 177 ✅ +1 817  0 💤 ±0  0 ❌ ±0 
29 178 runs  +1 817  29 178 ✅ +1 817  0 💤 ±0  0 ❌ ±0 

Results for commit 9464978. ± Comparison against base commit 36da1b8.

This pull request removes 23 and adds 1837 tests. Note that renamed tests count towards both.
IDE
IDE, "4diac$NIDE"
IDE, '4diac$NIDE'
org.eclipse.fordiac.ide.test.model.eval.fb.SimpleFBEvaluatorTest ‑ testDirectlyDerivedAttribute
org.eclipse.fordiac.ide.test.model.eval.fb.SimpleFBEvaluatorTest ‑ testStructAttribute
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[14] StringValueConverter, '4diac$NIDE', 4diac
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[15] StringValueConverter, '4diac$P$R$TIDE', 4diac
 IDE
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[22] WStringValueConverter, "4diac$NIDE", 4diac
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[23] WStringValueConverter, "4diac$P$R$TIDE", 4diac
 IDE
org.eclipse.fordiac.ide.test.model.value.ValueConverterTest ‑ toStringTest(ValueConverter, String, Object)[27] StructValueConverter [NumericValueConverter], (a := 17, b := 4), {b=4, a=17}
…
org.eclipse.fordiac.ide.model.datatype.helper.TypeDeclarationParserTest ‑ testCheckVariableArrayBounds
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentMLBlockReformatTest
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestMLBlock
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestMLUnwrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestMLWrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestSLUnwrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.Formatter2Test ‑ commentStabilityTestSLWrapped
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorPartialAccessTest ‑ testValidPartialAccessOnArraySubscript
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorTest ‑ testBinaryOperatorResultType(String, String, String) 1000: LT with WORD and BOOL
org.eclipse.fordiac.ide.structuredtextfunctioneditor.tests.STFunctionValidatorTest ‑ testBinaryOperatorResultType(String, String, String) 1001: LE with WORD and BOOL
…

♻️ This comment has been updated with latest results.

@diplfranzhoepfinger

Copy link
Copy Markdown
Contributor

please do not delete. i still want to bring this working.
have one Customer in Need of this.

@K019N

K019N commented Jan 28, 2025

Copy link
Copy Markdown

Mabye you have a typo in ModbusBusAdapter.adp on line 11: "" -- you use zero instead of letter O??

@mx990

mx990 commented Jan 28, 2025

Copy link
Copy Markdown
Member Author

You are correct, thanks for noting!

@diplfranzhoepfinger

Copy link
Copy Markdown
Contributor

Thanks !

@github-actions

Copy link
Copy Markdown

This PR has been marked as stale because it has been open for 45 days with no activity.

@github-actions github-actions Bot added the stale This issue is stale label Jun 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stale This issue is stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants