Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use objects instead of tuples in the generated samples #203

Merged
merged 7 commits into from
Jan 8, 2024

Conversation

Geal
Copy link
Contributor

@Geal Geal commented Jan 6, 2024

  • use objects instead of tuples because tuples are serialized as arrays in JSON
  • instead of having a list of objects containing each a fact and its origin, let's have a map of origin -> list of facts
  • sort facts, rules, checks etc should be sorted (sorting strings, not objects, to keep it simple), because we use sets everywhere, and their order can be random

@Geal Geal merged commit 29030e0 into main Jan 8, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant