disambiguate empty sets from empty maps #252
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
according to the grammar, `{}` could either mean *empty set* or *empty map*. Due to how the parser was written, it was always an empty set, and there was no way to have an empty map literal.
This is an issue because empty maps would still be displayed as `{}`, and maps have a different api than sets, resulting in evaluation errors.
This commit introduces `{,}` as the empty set literal, while `{}` is the empty map. The goal here is to be consistent with JSON, the reason why we chose the current syntax for arrays and maps.
CodSpeed Performance ReportMerging #252 will not alter performanceComparing Summary
|
divarvel
force-pushed
the
empty-set-literals
branch
2 times, most recently
from
3accb7a to
022120c
Compare
divarvel
force-pushed
the
empty-set-literals
branch
2 times, most recently
from
5a2a5fb to
3cceb75
Compare
divarvel
force-pushed
the
empty-set-literals
branch
from
3cceb75 to
cd5d154
Compare
|
coverage is OK, with tarpaulin run locally: 66.12% coverage, 5033/7612 lines covered, +0.54% change in coverage i haven’t found the reason why tarpaulin fails in CI |
Geal
reviewed
Nov 29, 2024
biscuit-auth/src/datalog/mod.rs
Outdated
Comment on lines
746
to
747
| #[cfg(test)] | ||
| const DEFAULT_DURATION_MILLIS: u64 = 1; | ||
| #[cfg(not(test))] | ||
| const DEFAULT_DURATION_MILLIS: u64 = 10_000; |
There was a problem hiding this comment.
shouldn't they be reversed? The longer one in tests?
There was a problem hiding this comment.
(i had removed the commit anyway but i’ll give another try)
Geal
approved these changes
Nov 29, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
according to the grammar,
{}could either mean empty set or empty map. Due to how the parser was written, it was always an empty set, and there was no way to have an empty map literal.This is an issue because empty maps would still be displayed as
{}, and maps have a different api than sets, resulting in evaluation errors.This commit introduces
{,}as the empty set literal, while{}is the empty map. The goal here is to be consistent with JSON, the reason why we chose the current syntax for arrays and maps.