Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/implement-matched-pub-and-sub #525

Merged
merged 3 commits into from
Feb 4, 2025
Merged

feature/implement-matched-pub-and-sub #525

merged 3 commits into from
Feb 4, 2025

Conversation

trittsv
Copy link
Contributor

@trittsv trittsv commented Feb 3, 2025

This PR implements the functions matched_publicationsand matched_subscriptions.

eboasson
eboasson approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@eboasson eboasson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ISOCPP_DDSC_RESULT_CHECK_AND_THROW throws when rc < 0, so yes, this should be fine 🙂 Thank you!

@eboasson eboasson merged commit 6cccf41 into eclipse-cyclonedds:master Feb 4, 2025
20 checks passed
@trittsv trittsv deleted the feature/implement-matched-pub-and-sub branch February 4, 2025 11:24
@trittsv
Copy link
Contributor Author

trittsv commented Feb 4, 2025

thank you for merging :)

@eboasson
Copy link
Contributor

eboasson commented Feb 4, 2025

Thank you for contributing! The merging bit is the easy bit 😀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eboasson eboasson eboasson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trittsv @eboasson