Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to use DS 1.4 #150

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Conversation

laeubi
Copy link
Contributor

@laeubi laeubi commented Jan 5, 2025

PDE since a while supports DS 1.4 so it would be good to use it for ECF as well so it could potentially leverage new features.

@scottslewis
Copy link
Contributor

I'm not going to merge this until the auto build succeeds. It's failing in the httpclient5.win32 fragment compile...with an exception that I don't understand here:

https://github.com/eclipse/ecf/actions/runs/12618122370/job/35161178087?pr=150#step:5:2837

Caused by: java.lang.ClassNotFoundException: org.eclipse.jgit.internal.JGitText

@laeubi
Copy link
Contributor Author

laeubi commented Jan 8, 2025

This is not the error (it actually is Unresolved requirement: Require-Capability: osgi.extender; filter:="(&(osgi.extender=osgi.component)(version>=1.4.0)(!(version>=2.0.0)))") but it both things are cause by an old Tycho version probably.

@laeubi
Copy link
Contributor Author

laeubi commented Jan 8, 2025

I think this requires first:

@scottslewis
Copy link
Contributor

I think this requires first:

* [Use latest Tycho version #152](https://github.com/eclipse/ecf/pull/152)

This has been merged to master.

PDE since a while supports DS 1.4 so it would be good to use it for ECF
as well so it could potentially leverage new features.
@scottslewis scottslewis merged commit 28d52fd into eclipse-ecf:master Jan 8, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants