feat: introduce messages and JSON-LD transformers for DCP issuer #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...edc/identityhub/protocols/dcp/issuer/api/v1alpha/credentialrequest/CredentialRequestApi.java
Dismissed
Show dismissed
Hide dismissed
...tyhub/protocols/dcp/issuer/api/v1alpha/credentialrequest/CredentialRequestApiController.java
Dismissed
Show dismissed
Hide dismissed
| @@ -30,18 +29,18 @@ | |||
| @Path("/v1alpha/requests") | |||
| public class CredentialRequestStatusApiController implements CredentialRequestStatusApi { | |||
|
|
|||
| public CredentialRequestStatusApiController(TypeTransformerRegistry dcpRegistry) { | |||
Check notice
Code scanning / CodeQL
Useless parameter Note
wolf4ood
force-pushed
the
feat/544_dcp_issuance_messages
branch
4 times, most recently
from
21f00cf to
2fc5099
Compare
paullatzelsperger
approved these changes
Feb 6, 2025
| """; | ||
| } | ||
|
|
||
| @Schema(name = "IssuerMetadata", example = IssuerMetadataSchema.RESPONSE_EXAMPLE) |
There was a problem hiding this comment.
I wonder if we should utilize the externalDoc functionality of OpenAPI to directly reference relevant parts of the DCP specification...
for a separate PR of course, but that would guarantee consistency.
There was a problem hiding this comment.
We could also remove the OpenApi docs and use directly the specification as we do for DSP
...c/main/java/org/eclipse/edc/identityhub/protocols/dcp/issuer/spi/model/CredentialObject.java
Show resolved
Hide resolved
wolf4ood
force-pushed
the
feat/544_dcp_issuance_messages
branch
from
2fc5099 to
9bc3cdb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Introduces transformers for:
CredentialRequestMessageIssuerMetadataCredentialStatusCredentialObjectMove all the issuer relates stuff under
dcp-issuersubfolder indcpprotocolMoves messages types under the
dcp-issuer-spimoduleWhy it does that
Serde of issuance messages
Further notes
List other areas of code that have changed but are not necessarily linked to the main feature. This could be method
signature changes, package declarations, bugs that were encountered and were fixed inline, etc.
Who will sponsor this feature?
Please @-mention the committer that will sponsor your feature.
Linked Issue(s)
Closes #544
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.