Median Heuristic implemented #1107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented a Median Heuristic that works similarly to the Barycenter Heuristic. Added the appropriate option called crossingMinimization.strategy: MEDIAN_LAYER_SWEEP
removed all references to dedicated MedianHeuristicProperties class and moved the respective properties to the InternalProperties class. Also, added some code to the weightComparator in MedianHeuristic to hopefully prevent accessing as yet uninitialized properties.
soerendomroes
requested changes
May 21, 2025
...org.eclipse.elk.alg.layered/src/org/eclipse/elk/alg/layered/p3order/BarycenterHeuristic.java
Outdated
Show resolved
Hide resolved
...org.eclipse.elk.alg.layered/src/org/eclipse/elk/alg/layered/p3order/BarycenterHeuristic.java
Outdated
Show resolved
Hide resolved
...se.elk.alg.layered/src/org/eclipse/elk/alg/layered/options/CrossingMinimizationStrategy.java
Outdated
Show resolved
Hide resolved
soerendomroes
approved these changes
May 21, 2025
...se.elk.alg.layered/src/org/eclipse/elk/alg/layered/options/CrossingMinimizationStrategy.java
Outdated
Show resolved
Hide resolved
...ins/org.eclipse.elk.alg.layered/src/org/eclipse/elk/alg/layered/p3order/MedianHeuristic.java
Outdated
Show resolved
Hide resolved
|
I suggest to add a test for this, similar to this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a Median Heuristic that works similarly to the Barycenter Heuristic. Added the appropriate option called
crossingMinimization.strategy: MEDIAN_LAYER_SWEEP