Configure Maven compiler level #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Maven build didn't configure any JDK target level for compilation. Neither for Java code, nor for Xtext generated code. The new properties configure the Java compiler (maven.compiler.release) and the Xtext generator (if takes its default from the maven-compiler-plugin, therefore we set source/target of the compiler, even though that looks superfluous after the release property). Fixes eclipse-elk#1114. Signed-off-by: Michael Keppler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Maven build didn't configure any JDK target level for compilation. Neither for Java code, nor for Xtext generated code. The new properties configure the Java compiler (maven.compiler.release) and the Xtext generator (if takes its default from the maven-compiler-plugin, therefore we set source/target of the compiler, even though that looks superfluous after the release property).
Fixes #1114.