Skip to content

Conversation

@Eddykasp
Copy link
Member

@Eddykasp Eddykasp commented Jul 2, 2025

this is following the guide by eclipse: https://eclipse-cbi.github.io/cbi-website/best-practices/github-actions/central-portal/index.html

(not sure if we want autopublish? they list it as best practice)

I think we may still have to add the otterdog config described in there

this is following the guide by eclipse: https://eclipse-cbi.github.io/cbi-website/best-practices/github-actions/central-portal/index.html

(not sure if we want autopublish? they list it as best practice)

I think we may still have to add the otterdog config described in there

Signed-off-by: Max Kasperowski <[email protected]>
@Eddykasp Eddykasp requested a review from soerendomroes July 2, 2025 07:01
@soerendomroes
Copy link
Contributor

I remember reading somewhere that we also have to change the url of something. Maybe we also need the snapshot publishing?

Signed-off-by: Sören Domrös <[email protected]>
build/pom.xml Outdated
Comment on lines 121 to 122
<waitUntil>published</waitUntil>
<centralSnapshotsUrl>https://central.sonatype.com/repository/maven-snapshots/</centralSnapshotsUrl>
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is the indentation off on these two lines?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks fine for me, but I accidentally commit it. How do they look like for you?
image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no looks good now, my diff looked wrong earlier

@soerendomroes soerendomroes merged commit 54c88aa into master Jul 29, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants