fix incorrect node size calculation in topdown fallback case #1152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soerendomroes
requested changes
Jul 11, 2025
There was a problem hiding this comment.
This looks like you are taking the padding into account now. However, I suggest adding a test for this since padding is always a little intricate. Do you have test cases for top-down already? Maybe just one or two tests that might alert us if something fails.
Check that calculated node dimensions correctly include padding in the fallback case of topdown layout where no approximator is set.
|
@soerendomroes this should be ready to merge now if the dash-licence-tool API would work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where paddings and micro layout were not correctly taken into consideration when no topdown size approximator was set.