-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#58] add functionality to vec #59
[#58] add functionality to vec #59
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #59 +/- ##
==========================================
+ Coverage 77.95% 77.98% +0.02%
==========================================
Files 172 172
Lines 18707 18729 +22
==========================================
+ Hits 14583 14605 +22
Misses 4124 4124
|
f56e66a
to
1c57b44
Compare
@elfenpiff I guess this PR is based on another one. I'll wait until that one is merged until I do the review |
1c57b44
to
5aea9c1
Compare
for i in 0..self.len() { | ||
if other[i] != self[i] { | ||
return false; | ||
} | ||
} | ||
|
||
true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as food for thought, this would be the equivalent approach with iterators
self.iter()
.zip(other.iter())
.try_for_each(|(lhs, rhs)| if lhs == rhs { Some(()) } else { None })
.is_some()
…d_from_slice to (FixedSize)Vec
5aea9c1
to
9ec7cb0
Compare
Notes for Reviewer
Please review #57 first since this PR is based on it.
Pre-Review Checklist for the PR Author
SPDX-License-Identifier: Apache-2.0 OR MIT
iox2-123-introduce-posix-ipc-example
)[#123] Add posix ipc example
)task-list-completed
)Checklist for the PR Reviewer
Post-review Checklist for the PR Author
References
Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.
Closes #58