Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58] add functionality to vec #59

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Dec 25, 2023

Notes for Reviewer

Please review #57 first since this PR is based on it.

Pre-Review Checklist for the PR Author

  1. Add sensible notes for the reviewer
  2. PR title is short, expressive and meaningful
  3. Relevant issues are linked
  4. Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  5. Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  6. Commits messages are according to this guideline
  7. Tests follow the best practice for testing
  8. Changelog updated in the unreleased section including API breaking changes
  9. Assign PR to reviewer
  10. All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  1. All open points are addressed and tracked via issues

References

Use either 'Closes #123' or 'Relates to #123' to reference the corresponding issue.

Closes #58

@elfenpiff elfenpiff requested a review from elBoberido December 25, 2023 22:55
@elfenpiff elfenpiff self-assigned this Dec 25, 2023
@elfenpiff elfenpiff changed the title Iox2 58 add functionality to vec [#58] add functionality to vec Dec 25, 2023
Copy link

codecov bot commented Dec 25, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (b9f6f66) 77.95% compared to head (5aea9c1) 77.98%.

❗ Current head 5aea9c1 differs from pull request most recent head 9ec7cb0. Consider uploading reports for the commit 9ec7cb0 to get more accurate results

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #59      +/-   ##
==========================================
+ Coverage   77.95%   77.98%   +0.02%     
==========================================
  Files         172      172              
  Lines       18707    18729      +22     
==========================================
+ Hits        14583    14605      +22     
  Misses       4124     4124              
Files Coverage Δ
iceoryx2-bb/container/src/vec.rs 89.70% <96.15%> (+1.24%) ⬆️

@elfenpiff elfenpiff force-pushed the iox2-58-add-functionality-to-vec branch from f56e66a to 1c57b44 Compare December 25, 2023 23:04
@elBoberido
Copy link
Member

@elfenpiff I guess this PR is based on another one. I'll wait until that one is merged until I do the review

@elfenpiff elfenpiff force-pushed the iox2-58-add-functionality-to-vec branch from 1c57b44 to 5aea9c1 Compare December 29, 2023 10:53
Comment on lines +165 to +171
for i in 0..self.len() {
if other[i] != self[i] {
return false;
}
}

true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just as food for thought, this would be the equivalent approach with iterators

self.iter()
    .zip(other.iter())
    .try_for_each(|(lhs, rhs)| if lhs == rhs { Some(()) } else { None })
    .is_some()

@elfenpiff elfenpiff force-pushed the iox2-58-add-functionality-to-vec branch from 5aea9c1 to 9ec7cb0 Compare December 29, 2023 17:39
@elfenpiff elfenpiff merged commit 26d979e into eclipse-iceoryx:main Dec 29, 2023
2 of 17 checks passed
@elfenpiff elfenpiff deleted the iox2-58-add-functionality-to-vec branch December 29, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add std functionality to shm-comp Vec/FixedSizeVec
2 participants