Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#602] Introduce marker traits and composable marker trait generator … #603

Merged

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 23, 2025

Notes for Reviewer

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Relates to #602

@elfenpiff elfenpiff requested a review from elBoberido January 23, 2025 23:32
@elfenpiff elfenpiff self-assigned this Jan 23, 2025
@elfenpiff elfenpiff force-pushed the iox2-602-introduce-shm-marker-traits branch from c7281ae to 1d3642b Compare January 23, 2025 23:40
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (dd42fc9) to head (247249f).
Report is 84 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##             main   #603       +/-   ##
=========================================
- Coverage   78.77%      0   -78.78%     
=========================================
  Files         199      0      -199     
  Lines       24118      0    -24118     
=========================================
- Hits        18999      0    -18999     
+ Misses       5119      0     -5119     

see 199 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 97f36a1 into eclipse-iceoryx:main Feb 14, 2025
52 checks passed
@elfenpiff elfenpiff deleted the iox2-602-introduce-shm-marker-traits branch February 14, 2025 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants