Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#610] extend benchmarks #611

Merged
merged 5 commits into from
Jan 30, 2025

Conversation

elfenpiff
Copy link
Contributor

@elfenpiff elfenpiff commented Jan 30, 2025

Notes for Reviewer

The user shall be able to utilize our benchmarks to test more complex setups. For instance sending a message from a publisher with N subscribers or notify N listeners. The benchmarks were extended to support this use case.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #610

@elfenpiff elfenpiff requested a review from orecham January 30, 2025 08:22
@elfenpiff elfenpiff self-assigned this Jan 30, 2025
Copy link

codecov bot commented Jan 30, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.86%. Comparing base (d900b9c) to head (49c288e).
Report is 15 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #611      +/-   ##
==========================================
+ Coverage   78.79%   78.86%   +0.06%     
==========================================
  Files         200      200              
  Lines       24443    24443              
==========================================
+ Hits        19260    19277      +17     
+ Misses       5183     5166      -17     

see 11 files with indirect coverage changes

@elfenpiff elfenpiff merged commit 5e0edcd into eclipse-iceoryx:main Jan 30, 2025
48 of 49 checks passed
@elfenpiff elfenpiff deleted the iox2-610-extend-benchmarks branch January 30, 2025 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend benchmarks so that the number of endpoints can be configured.
2 participants