Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#604] Introduce libc platform #614

Merged

Conversation

elBoberido
Copy link
Member

@elBoberido elBoberido commented Jan 31, 2025

Notes for Reviewer

This PR completes to platform abstraction based on the libc crate. Currently it is hidden behind the libc_platform feature flag and currently only works only on Linux. In theory it should be possible to base other platforms than Linux on the libc crate but that's something for the future.

The feature flag can currently also only be used with cargo and cmake. I'm not quite sure how hard it would be to support both, the libc platform and the bindgen generated one, at the same time.

Pre-Review Checklist for the PR Author

  • Add sensible notes for the reviewer
  • PR title is short, expressive and meaningful
  • Consider switching the PR to a draft (Convert to draft)
    • as draft PR, the CI will be skipped for pushes
  • Relevant issues are linked in the References section
  • Every source code file has a copyright header with SPDX-License-Identifier: Apache-2.0 OR MIT
  • Branch follows the naming format (iox2-123-introduce-posix-ipc-example)
  • Commits messages are according to this guideline
  • Tests follow the best practice for testing
  • Changelog updated in the unreleased section including API breaking changes
  • Assign PR to reviewer
  • All checks have passed (except task-list-completed)

Checklist for the PR Reviewer

  • Commits are properly organized and messages are according to the guideline
  • Unit tests have been written for new behavior
  • Public API is documented
  • PR title describes the changes

Post-review Checklist for the PR Author

  • All open points are addressed and tracked via issues

References

Closes #604

@elBoberido elBoberido force-pushed the iox2-604-libc-platform-part-2 branch 12 times, most recently from db1809c to 1c91f75 Compare January 31, 2025 03:47
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 64.70588% with 18 lines in your changes missing coverage. Please review.

Project coverage is 79.07%. Comparing base (5e0edcd) to head (8fc2723).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
iceoryx2-pal/posix/src/linux/signal.rs 43.33% 17 Missing ⚠️
iceoryx2-bb/posix/src/signal.rs 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #614      +/-   ##
==========================================
- Coverage   79.19%   79.07%   -0.12%     
==========================================
  Files         200      200              
  Lines       24124    24156      +32     
==========================================
- Hits        19105    19102       -3     
- Misses       5019     5054      +35     
Files with missing lines Coverage Δ
iceoryx2-pal/posix/src/lib.rs 58.82% <ø> (ø)
iceoryx2-pal/posix/src/linux/fcntl.rs 96.00% <100.00%> (ø)
iceoryx2-pal/posix/src/linux/pthread.rs 95.10% <100.00%> (+0.28%) ⬆️
iceoryx2-pal/posix/src/linux/stat.rs 100.00% <100.00%> (ø)
iceoryx2-pal/posix/src/linux/types.rs 100.00% <100.00%> (ø)
iceoryx2-bb/posix/src/signal.rs 74.43% <80.00%> (-0.29%) ⬇️
iceoryx2-pal/posix/src/linux/signal.rs 45.16% <43.33%> (-54.84%) ⬇️

... and 9 files with indirect coverage changes

@elBoberido elBoberido force-pushed the iox2-604-libc-platform-part-2 branch 17 times, most recently from 7b3cfac to ed2f5fd Compare February 2, 2025 22:18
@elBoberido elBoberido changed the title [WIP] [604] Introduce libc platform [604] Introduce libc platform Feb 2, 2025
@elBoberido elBoberido changed the title [604] Introduce libc platform [#604] Introduce libc platform Feb 2, 2025
@elBoberido elBoberido force-pushed the iox2-604-libc-platform-part-2 branch from ed2f5fd to c773832 Compare February 2, 2025 22:57
@elBoberido elBoberido requested a review from elfenpiff February 2, 2025 22:57
@elBoberido elBoberido self-assigned this Feb 2, 2025
@elBoberido elBoberido force-pushed the iox2-604-libc-platform-part-2 branch from c773832 to 8fc2723 Compare February 2, 2025 22:59
@elBoberido elBoberido merged commit 76ed6dd into eclipse-iceoryx:main Feb 3, 2025
53 of 54 checks passed
@elBoberido elBoberido deleted the iox2-604-libc-platform-part-2 branch February 3, 2025 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intoduce platform abstraction based on the 'libc' crate
2 participants