Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Replace / Remove existing functionality from kuksa-java-sdk #121

Merged

Conversation

wba2hi
Copy link
Contributor

@wba2hi wba2hi commented Jan 31, 2025

Remove existing functionality from kuksa-java-sdk:

  • vss-core because it has been moved to kuksa-java-sdk
  • vss-processor-plugin because it has been moved to Velocitas vehicle-app-java-sdk
  • vss-processor because it has been moved to Velocitas vehicle-app-java-sdk

Currently there is no clear idea what the added value of the android repo will be. Right now it's just the consumer-proguard rules and the AndroidManifest which predefines the Internet permission (and therefore user's don't need to add it manually)

For compability purposes of the TestApp the Velocitas vss-processor-plugin was added again.

Migrated to Gradle Nexus Publish Plugin, so we can also automatically release using GitHub Actions.

@wba2hi wba2hi force-pushed the feature/integrate-kuksa-java-sdk branch from 5e96b73 to b5e5276 Compare January 31, 2025 14:00
@wba2hi
Copy link
Contributor Author

wba2hi commented Feb 3, 2025

Closes #120

@wba2hi wba2hi linked an issue Feb 3, 2025 that may be closed by this pull request
Copy link
Contributor

@Chrylo Chrylo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mainly around java version used in ci and files. Maybe I'm not the expert. Just elaborate ;)

.github/actions/setup-project/action.yaml Show resolved Hide resolved
app/build.gradle.kts Show resolved Hide resolved
buildSrc/build.gradle.kts Show resolved Hide resolved
gradle/wrapper/gradle-wrapper.jar Show resolved Hide resolved
kuksa-sdk/build.gradle.kts Show resolved Hide resolved
samples/build.gradle.kts Show resolved Hide resolved
Copy link
Contributor

@lukasmittag lukasmittag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doubts resolved in comments. LGTM

@lukasmittag lukasmittag merged commit 1902000 into eclipse-kuksa:main Feb 5, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove redundant code after separation into "kuksa-java-sdk"
3 participants