-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: Replace / Remove existing functionality from kuksa-java-sdk #121
feature: Replace / Remove existing functionality from kuksa-java-sdk #121
Conversation
5e96b73
to
b5e5276
Compare
... vss-core was moved to kuksa-java-sdk. Therefore removing it from kuksa-android-sdk.
vss-processor-plugin was moved to Velocitas vehicle-app-java-sdk and therefore removed from here.
the vss-processor is no longer required, the generation is now triggered from Velocitas vss-processor-plugin
b5e5276
to
3de240e
Compare
Closes #120 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mainly around java version used in ci and files. Maybe I'm not the expert. Just elaborate ;)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
doubts resolved in comments. LGTM
Remove existing functionality from kuksa-java-sdk:
Currently there is no clear idea what the added value of the android repo will be. Right now it's just the consumer-proguard rules and the AndroidManifest which predefines the Internet permission (and therefore user's don't need to add it manually)
For compability purposes of the TestApp the Velocitas vss-processor-plugin was added again.
Migrated to Gradle Nexus Publish Plugin, so we can also automatically release using GitHub Actions.