-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
publish, set, actuate non-interactive cli #138
publish, set, actuate non-interactive cli #138
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #138 +/- ##
==========================================
- Coverage 59.47% 59.41% -0.07%
==========================================
Files 34 34
Lines 15112 15128 +16
==========================================
Hits 8988 8988
- Misses 6124 6140 +16 ☔ View full report in Codecov by Sentry. |
should write some tests but fix is needed by another person so will do a follow up PR for that. |
Does it make sense to have "set" in commandline , when the CLI interface itself does not seem to have it? |
Should have help text for all new options:
|
No, makes no sense at least for kuksa.val.v1 because in sdv.databroker.v1 there is a set so keep it and throw an unimplemented exception. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me. lgtm 🏴☠️
Adds
publish
actuate
set
from cli for kuksa.val.v1set
calls the same aspublish
.calls like these are now supported:
same for docker: