[#14] Addressed review comments

eclipse-kuksa · Feb 5, 2025 · 6263037 · 6263037
1 parent c645712
commit 6263037
Show file tree

Hide file tree

Showing 20 changed files with 78 additions and 3,191 deletions.
diff --git a/can-protocol-adapter/Cargo.lock b/can-protocol-adapter/Cargo.lock
diff --git a/can-protocol-adapter/Cargo.toml b/can-protocol-adapter/Cargo.toml
@@ -34,8 +34,8 @@ serde_json = "1.0"
 socketcan-isotp = "1.0.2"
 tonic = "0.11.0"
 databroker-proto = { path = "submodules/kuksa-databroker/databroker-proto"}
-kuksa-common = { path = "lib/common"}
-kuksa = { path = "lib/kuksa"}
+kuksa-common = { path = "submodules/kuksa-databroker/lib/common"}
+kuksa = { path = "submodules/kuksa-databroker/lib/kuksa"}
 can-dbc="6.0.0"
 codegen = "0.2"
 byteorder = "1.3"

diff --git a/can-protocol-adapter/README.md b/can-protocol-adapter/README.md
@@ -22,7 +22,7 @@ It can be used for various applications, including communication between CAN bus
 
 ## The basic functionality works as follows:
 
-The application connects to the SocketCAN interface and sends all CAN requests, as specified in the PID table of the config file, based on a defined interval. The responses are read, and the raw CAN data is parsed according to the DBC file signals. The CAN signals are then translated into VSS data points based on the VSS and DBC signal mappings described in the config file. The respective VSS data points are then sent to the Kuksa Databroker.
+The CAN Protocol Adapter connects to the SocketCAN interface and sends all CAN requests, as specified in the PID table of the config file, based on a defined interval. The responses are read, and the raw CAN data is parsed according to the DBC file signals. The CAN signals are then translated into VSS data points based on the VSS and DBC signal mappings described in the config file. The respective VSS data points are then sent to the Kuksa Databroker.
 
 ![CAN-Protocol-adapter](assets/context.jpg)
 

diff --git a/can-protocol-adapter/lib/Cargo.toml b/can-protocol-adapter/lib/Cargo.toml
diff --git a/can-protocol-adapter/lib/common/Cargo.toml b/can-protocol-adapter/lib/common/Cargo.toml