Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding a simple persistence provider (Replacement PR) #13

Merged
merged 5 commits into from
Dec 5, 2024
Merged

Adding a simple persistence provider (Replacement PR) #13

merged 5 commits into from
Dec 5, 2024

Conversation

erikbosch
Copy link
Contributor

@erikbosch erikbosch commented Nov 6, 2024 •
edited
Loading

Replaces #11

SebastianSchildt and others added 2 commits November 6, 2024 15:00
@SebastianSchildt @erikbosch
Adding a simple persistence provider
f7b3f20 
Signed-off-by: Sebastian Schildt <[email protected]>

Added hint for building to the readme

format cargo file
@erikbosch
Fixing comment
f44ccd7
@erikbosch erikbosch changed the title Erik persist Adding a simple persistence provider (Replacement PR) Nov 6, 2024
@erikbosch erikbosch marked this pull request as ready for review November 6, 2024 14:01
@erikbosch erikbosch requested a review from lukasmittag November 6, 2024 14:02
@erikbosch erikbosch mentioned this pull request Nov 6, 2024
Closed
@SebastianSchildt
Copy link
Contributor

@MathiasDanzeisen is this functional, and includes everything you intended to have here? Or do we need to extend this? If so, should we merge already, and add further PRs as required?

MathiasDanzeisen
MathiasDanzeisen suggested changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@MathiasDanzeisen MathiasDanzeisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting up the pull request.
I suggested some changes in the Cargo script to build the demo without the djson lib at hand and improvements for documentation

kuksa-persistence-provider/Cargo.toml Outdated Show resolved Hide resolved
kuksa-persistence-provider/Cargo.toml Outdated Show resolved Hide resolved
kuksa-persistence-provider/Readme.md Outdated Show resolved Hide resolved
kuksa-persistence-provider/Readme.md Outdated Show resolved Hide resolved
kuksa-persistence-provider/Readme.md Outdated Show resolved Hide resolved
kuksa-persistence-provider/Readme.md Outdated Show resolved Hide resolved
erikbosch and others added 2 commits December 5, 2024 14:25
@erikbosch @MathiasDanzeisen
Apply suggestions from code review
7106596 
Co-authored-by: MathiasDanzeisen <[email protected]>
@erikbosch
Fix pre-commit
0378158 
Also doing cargo update
SebastianSchildt
SebastianSchildt approved these changes Dec 5, 2024
View reviewed changes
Copy link
Contributor

@SebastianSchildt SebastianSchildt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for providing/fixing this.

Merging this now. Once djson location is stable we can revisit, and add the URL.

@SebastianSchildt SebastianSchildt merged commit d95790a into eclipse-kuksa:main Dec 5, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MathiasDanzeisen MathiasDanzeisen MathiasDanzeisen requested changes

@SebastianSchildt SebastianSchildt SebastianSchildt approved these changes

@lukasmittag lukasmittag Awaiting requested review from lukasmittag

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erikbosch @SebastianSchildt @MathiasDanzeisen