fix(nm): Removed check of net.interfaces property #5531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
pierantoniomerlino
force-pushed
the
fix_net_interfaces_property_management
branch
from
2604207 to
6648e6f
Compare
Member
|
Since this PR is quite invasive (removing a snapshot property that's being there for... as long as the project exists) and we're in the middle of the release process, we decided to opt for a less invasive fix of the issue for the time being. The current issue is given by the fact that, due to how the Kura snapshot works, we cannot configure a network interface via Rest if it is not already in the snapshot (while via UI we can). This PR addresses the issue at snapshot level, we'll create a PR that addresses the issue at Rest API level. After this release we'll resurrect this PR. To work on the new PR we'll need to revert the already contributed changes in #5522 |
Contributor
|
This pull request is stale because it has been open for 60 days with no activity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the check of the content of the
net.interfacesproperty when a new configuration is applied. Moreover, the webUI behavior has been changed to take into account the fact that a network interface cannot be listed in that property.