Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web2): Fixed whiteboard services unregistration and context managing #5737

Merged
merged 9 commits into from
Feb 21, 2025

Conversation

salvatore-coppola
Copy link
Contributor

@salvatore-coppola salvatore-coppola commented Feb 21, 2025

This PR:

  • fixes the process of whiteboard services unregistration and add some debug logs.
  • add the suggested Scope to resources and servlets as described here
  • change the ServletContextHelper naming to force context destruction.

@salvatore-coppola salvatore-coppola force-pushed the fix-servlets-unregistration branch from 1bd1477 to d2e9d0a Compare February 21, 2025 08:49
@salvatore-coppola salvatore-coppola force-pushed the fix-servlets-unregistration branch 2 times, most recently from 54ac94c to 8cfa73f Compare February 21, 2025 09:18
@salvatore-coppola salvatore-coppola changed the title fix(web2): Fixed servlets unregistration fix(web2): Fixed whiteboard services unregistration and context managing Feb 21, 2025
@nicolatimeus
Copy link
Contributor

nicolatimeus commented Feb 21, 2025

What is the purpose of setting the service.scope property? In my opinion in this case it has no effect since the services are registered manually and there will be a single instance of them for each resource, it would have some effect if the services implement PrototypeServiceFactory or ServiceFactory (which is not the case) or if the services were managed by DS

@salvatore-coppola
Copy link
Contributor Author

salvatore-coppola commented Feb 21, 2025

What is the purpose of setting the service.scope property? In my opinion in this case it has no effect since the services are registered manually and there will be a single instance of them for each resource, it would have some effect if the services implement PrototypeServiceFactory or ServiceFactory (which is not the case) or if the services were managed by DS

It certainly has no effect but as the article says it is not wrong specify that a servlet has a prototype scope aligned with the Jakarta-RS design.
BTW i'll remove it.

@salvatore-coppola salvatore-coppola force-pushed the fix-servlets-unregistration branch from ff32198 to 373f12f Compare February 21, 2025 13:42
@salvatore-coppola salvatore-coppola merged commit c0f386b into develop Feb 21, 2025
5 checks passed
@salvatore-coppola salvatore-coppola deleted the fix-servlets-unregistration branch February 21, 2025 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants