-
Notifications
You must be signed in to change notification settings - Fork 315
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web2): Fixed whiteboard services unregistration and context managing #5737
Conversation
1bd1477
to
d2e9d0a
Compare
54ac94c
to
8cfa73f
Compare
What is the purpose of setting the service.scope property? In my opinion in this case it has no effect since the services are registered manually and there will be a single instance of them for each resource, it would have some effect if the services implement PrototypeServiceFactory or ServiceFactory (which is not the case) or if the services were managed by DS |
It certainly has no effect but as the article says it is not wrong specify that a servlet has a prototype scope aligned with the Jakarta-RS design. |
ff32198
to
373f12f
Compare
This PR:
ServletContextHelper
naming to force context destruction.