fix(nm): Fixed typo in NMSettingsConverter #5741
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: pierantoniomerlino <[email protected]>
mattdibi
reviewed
Feb 21, 2025
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
mattdibi
reviewed
Feb 21, 2025
...org.eclipse.kura.nm/src/main/java/org/eclipse/kura/nm/configuration/NMSettingsConverter.java
Outdated
Show resolved
Hide resolved
mattdibi
previously approved these changes
Feb 21, 2025
…figuration/NMSettingsConverter.java Co-authored-by: Mattia Dal Ben <[email protected]>
…figuration/NMSettingsConverter.java Co-authored-by: Mattia Dal Ben <[email protected]>
Too late... |
mattdibi
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes a fix for a typo in the property names used in the
buildPPPSettingsmethod within theNMSettingsConverter.javafile. The typo correction ensures that the correct property names are used when retrieving configuration settings.Fixes to property names:
The correct names are lcp-echo-failure and lcp-echo-interval. However, we keep the wrong names for compatibility.