DefaultWorkspaceManager: improve error handling in traverseFolder #2047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lipse-langium#2044) - check if directory exists eg in workspaces a directory could have been delete since the last start - catch all errors while reading the directory content
Contributor
sailingKieler
left a comment
sailingKieler
left a comment
There was a problem hiding this comment.
Thank you @tomsontom for taking the initiative about this! 🙏
I have an idea for an improvement, see below.
…lipse-langium#2044) - removed check for exists and let readDirectory fail
msujew
approved these changes
Oct 23, 2025
Member
msujew
left a comment
msujew
left a comment
There was a problem hiding this comment.
LGTM, thank you. We'll include this in a patch release soon.
msujew
pushed a commit
that referenced
this pull request
Nov 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #2044