Skip to content

Improved internals of UriTrie to simplify customizations #2069

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
JohannesMeierSE merged 1 commit into from
Nov 20, 2025
Merged

Improved internals of UriTrie to simplify customizations #2069

JohannesMeierSE merged 1 commit into from
Nov 20, 2025

Conversation

@JohannesMeierSE
Copy link
Contributor

@JohannesMeierSE JohannesMeierSE commented Nov 20, 2025

This PR is a refactoring, which improves the internals of UriTrie to simplify customizations:

  • In a project, we needed to support custom URIs. Since the contributed normalizeUri didn't exist, we had to override all public methods instead.
  • Additionally I changed private visibilities to protected to enable even more customizations.

sailingKieler
sailingKieler approved these changes Nov 20, 2025
View reviewed changes
Copy link
Contributor

@sailingKieler sailingKieler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah 🚀

@JohannesMeierSE JohannesMeierSE merged commit a1f48f5 into main Nov 20, 2025
4 checks passed
@JohannesMeierSE JohannesMeierSE deleted the jm/uri-trie-customization branch November 20, 2025 09:16
@sailingKieler sailingKieler mentioned this pull request Nov 21, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sailingKieler sailingKieler sailingKieler approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JohannesMeierSE @sailingKieler