Fix return type of infix rules #2077
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nk-coding
reviewed
Dec 4, 2025
|
|
||
| private registerPrecedenceMap(rule: InfixRule): void { | ||
| const name = rule.name; | ||
| const name = getTypeName(rule); |
There was a problem hiding this comment.
does this work? in theory, you could have different rules with different precedences which however return the same type
sth like
infix OperatorExpression on IdExpression returns ComplexExpression:
'*' | '/'
> '+' | '-';
infix OperatorExpression2 on IdExpression returns ComplexExpression:
'%'
> '^';
Member
Author
There was a problem hiding this comment.
I guess that makes sense, thanks 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2075
Simply uses the
getTypeNamefunction to get the expected name of the AST node.