Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for syntax highlighting for Containerfile #292

Closed
erik-brangs opened this issue Dec 22, 2023 · 5 comments · Fixed by #307
Closed

Add support for syntax highlighting for Containerfile #292

erik-brangs opened this issue Dec 22, 2023 · 5 comments · Fixed by #307

Comments

@erik-brangs
Copy link

Some tools (e.g. Buildah) support Containerfile as an alternative to Dockerfile.

It would be nice if the Eclipse Linux Tools offered syntax highlighting for Containerfile-

@erik-brangs
Copy link
Author

I actually tried to implement this but I wasn't able to make it work. I looked at 502598e and tried to do it in a similar way.

I was only able to make it work for Containerfile.something but not for Containerfile:

diff --git a/containers/org.eclipse.linuxtools.docker.editor.ls/plugin.xml b/containers/org.eclipse.linuxtools.docker.editor.ls/plugin.xml
index f68b06f98d..a51f24f8a8 100644
--- a/containers/org.eclipse.linuxtools.docker.editor.ls/plugin.xml
+++ b/containers/org.eclipse.linuxtools.docker.editor.ls/plugin.xml
@@ -25,9 +25,9 @@
          point="org.eclipse.core.contenttype.contentTypes">
       <content-type
             base-type="org.eclipse.core.runtime.text"
-            file-extensions="Dockerfile,dockerfile"
-            file-names="Dockerfile"
-            file-patterns="Dockerfile.*"
+            file-extensions="Dockerfile,dockerfile,Containerfile,containerfile"
+            file-names="Dockerfile,Containerfile"
+            file-patterns="Dockerfile.*,Containerfile.*"
             id="org.eclipse.linuxtools.docker.editor.ls"
             name="Dockerfile"
             priority="normal">

@akurtakov
Copy link
Contributor

Is Containerfile just a rename of Dockerfile ?

@erik-brangs
Copy link
Author

Yes, it's just another name that's supposed to be more vendor-neutral.

akurtakov added a commit to akurtakov/org.eclipse.linuxtools that referenced this issue Jan 22, 2024
akurtakov added a commit to akurtakov/org.eclipse.linuxtools that referenced this issue Jan 22, 2024
akurtakov added a commit that referenced this issue Jan 22, 2024
@akurtakov
Copy link
Contributor

After the build completes youl should be able to install new dockertools from https://download.eclipse.org/linuxtools/updates-docker-nightly/ with support for Containerfile in it.

@erik-brangs
Copy link
Author

I installed the nightly in my Eclipse installation at work and the Containerfile syntax highlighting seems to work fine.

Thank you.

jjohnstn pushed a commit to jjohnstn/org.eclipse.linuxtools that referenced this issue Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants