Fix string literal conversion warnings in codegen and il #18465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dylanjtuttle
force-pushed
the
constCharAnyTime
branch
from
5d89c3e to
b114a1a
Compare
dylanjtuttle
changed the title
|
I notice that pull request eclipse-omr/omr#7185 contains changes to add |
Honestly I don't think I ever noticed the inconsistency. Fixed! |
dylanjtuttle
force-pushed
the
constCharAnyTime
branch
from
b114a1a to
c0805bf
Compare
hzongaro
reviewed
Dec 11, 2023
dylanjtuttle
force-pushed
the
constCharAnyTime
branch
from
c0805bf to
2ba413c
Compare
hzongaro
added
comp:jit
depends:omr
hzongaro
approved these changes
Dec 12, 2023
|
@dylanjtuttle, may I ask you to squash the new commit that addresses review comments into the other existing commits? |
dylanjtuttle
force-pushed
the
constCharAnyTime
branch
from
2ba413c to
0edf7ba
Compare
|
Jenkins test sanity.functional,sanity.openjdk all jdk8,jdk11,jdk17,jdk21 depends eclipse-omr/omr#7185 |
Fix string literal conversion warnings in runtime/compiler/codegen Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in runtime/compiler/il Signed-off-by: Dylan Tuttle <[email protected]>
Fix string literal conversion warnings in runtime/compiler/runtime Signed-off-by: Dylan Tuttle <[email protected]>
dylanjtuttle
force-pushed
the
constCharAnyTime
branch
from
0edf7ba to
874fe48
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards fixing AIX warnings about assigning string literals to non-const char pointers by adding 'const' qualifiers to some string variables and parameters (or worst case scenario, casting to
(char *)) in runtime/compiler/codegen and runtime/compiler/il.This PR contributes to (but does not close) #14859
This PR must be merged in coordination with eclipse-omr/omr#7185