AArch64: Fix String.hashCode() implementation #18508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes `inlineStringHashCode` so that `savedLengthReg` is copied to `lengthReg` when the reference count of`lengthNode` is > 1. Signed-off-by: Akira Saitoh <[email protected]>
|
Jenkins compile amac,alinux64 jdk17 |
knn-k
approved these changes
Nov 22, 2023
|
Tests on AArch64 Linux were run by an internal jenkins job: view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/19391/ All the tests (sanity.functional, sanity.system, extended.system, and sanity.openjdk with Java 8, 11, and 17) passed except for the following failures, which do not seem to be related to String.hashCode().
Tests on AArch64 macOS (sanity.functional with Java 11 and 17) were also successful: view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/19392/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes
inlineStringHashCodeso thatsavedLengthRegis copied tolengthRegwhen the reference count oflengthNodeis > 1.Resolves #18506.