Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Valhalla tests to compile with lw5 #18517

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

theresa-m
Copy link
Contributor

@theresa-m theresa-m commented Nov 23, 2023

This is the remaining change set to compile functional/Valhalla tests with lw5
at dc715159feda32945d5c2351ede9c6be04a64d6f (before aconst_init, ,
withfield removal).

The next step is identifying what needs to be done to get
all tests passing and updating to the head of lw5.

#18505 should be merged first

@theresa-m theresa-m added project:valhalla Used to track Project Valhalla related work comp:test labels Nov 23, 2023
@theresa-m theresa-m force-pushed the compilelw5tests branch 4 times, most recently from 7faafcb to b229c53 Compare November 23, 2023 21:01
@hangshao0
Copy link
Contributor

There are merge conflicts that need to be resolved.

This is the remaining change set to compile functional/Valhalla tests with lw5
at dc715159feda32945d5c2351ede9c6be04a64d6f (before aconst_init, <vnew>,
withfield removal).

The next step is identifying what needs to be done to get
all tests passing and updating to the head of lw5.

Signed-off-by: Theresa Mammarella <[email protected]>
@theresa-m
Copy link
Contributor Author

I have resolved the merge conflict.

Copy link
Contributor

@hangshao0 hangshao0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended winval jdknext

@hangshao0
Copy link
Contributor

Jenkins test sanity,extended aixval jdknext

@hangshao0 hangshao0 merged commit 0e169d4 into eclipse-openj9:master Nov 27, 2023
@theresa-m theresa-m deleted the compilelw5tests branch December 6, 2023 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp:test project:valhalla Used to track Project Valhalla related work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants