-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Coordinate Sampler Thread across a Checkpoint/Restore #18541
Conversation
538395f
to
ba8282a
Compare
@mpirvu could you please review? |
We will need to update the documentation regarding @mpirvu good for review again. Testing shows everything behaves as expected:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I have a couple of comments inline.
Also, there is the potential for the checkpoint to wait for an entire sampler period. If the checkpointing thread sends the interrupt when the sampler is not sleeping, the sampler will continue to run in its loop and then start sleeping. It will pick up the checkpoint intention after the sleep is over. Given that the sleep time is ~10 ms, this should not be a big problem.
Signed-off-by: Irwin D'Souza <[email protected]>
Signed-off-by: Irwin D'Souza <[email protected]>
904aa48
to
59db93b
Compare
jenkins test sanity all jdk17 |
I believe AIX failure is #8625 |
jenkins test sanity aix jdk17 |
Part of #16853