Need writeBarrier between resetting the state and freeContinuation #18573
Conversation
For weak memory ordering system such as PowerPC, we need to writeBarrier between resetting the state of continuation(set the state to unmounted) and freeing continuation/postUnmountContinuation during continuation unmounting to avoid potential assert/issue caused by inconsist state (in case the instructions are reordered). Signed-off-by: hulin <[email protected]>
|
Once this is approved we need PRs for 0.42 and 0.43 as well. |
|
jenkins test sanity alinux64 jdk21 |
|
jenkins test sanity zlinux jdk21 |
Multiple JIT server (@cjjdespres @mpirvu) and CRIU (@tajila @JasonFengJ9) failures are seen in the above PR build. These failures are unrelated to this PR since this PR only adds a write barrier. Started another PR build on zLinux to confirm no relation between the failures and this PR.
|
|
The JITServer failures or anything like the following is #18571 and should be resolved shortly.
|
|
The criu "Segmentation fault" failures are a machine problem. |
|
@LinHu2016 Can you please port this PR to the v0.42.0-release and v0.43.0-release branches? |
|
Hi @babsingh, There is potentially the case(the same assertion), which is discovered by another issue, might not be cover by this PR, I will hold for porting, we might have different solution to handle both cases, so this PR might be unnecessary. |
For weak memory ordering system such as PowerPC, we need to writeBarrier between resetting the state of continuation(set the state to unmounted) and freeing continuation/postUnmountContinuation during continuation unmounting to avoid potential assert/issue caused by inconsist state (in case the instructions are reordered).
related: #16728
Signed-off-by: hulin [email protected]