Return true from Unsafe.shouldBeInitialized when called from <clinit> #18719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When initialization of the class has started but not yet completed, and shouldBeInitialized is called from the initializing thread, its result should be true, but it has been returning false instead. DirectMethodHandle.checkInitialized calls ensureClassInitialized and then uses this method to determine whether initialization is incomplete because it is still ongoing on the current thread. This fix should allow that usage to work as intended.
|
jenkins test sanity.functional,sanity.openjdk alinux jdk21 |
|
Only known and unrelated CRIU failures are seen: |
babsingh
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When initialization of the class has started but not yet completed, and
shouldBeInitializedis called from the initializing thread, its result should be true, but it has been returning false instead.DirectMethodHandle.checkInitializedcallsensureClassInitializedand then uses this method to determine whether initialization is incomplete because it is still ongoing on the current thread. This fix should allow that usage to work as intended.