Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(0.48) romToRam cache follow up #20197

Merged
merged 2 commits into from
Sep 24, 2024
Merged

(0.48) romToRam cache follow up #20197

merged 2 commits into from
Sep 24, 2024

Conversation

theresa-m
Copy link
Contributor

Port from #20196

@theresa-m theresa-m requested a review from keithc-ca September 19, 2024 14:41
@theresa-m theresa-m force-pushed the findclass_cache_fix_0.48 branch from e1ae462 to f2bc9ac Compare September 19, 2024 14:53
@theresa-m theresa-m mentioned this pull request Sep 19, 2024
Merged
@pshipton
Copy link
Member

pshipton commented Sep 19, 2024 •
edited
Loading

Set as draft until the issues in the builds are resolved.
Sorry, wrong issue.

@keithc-ca keithc-ca marked this pull request as draft September 19, 2024 17:11
@theresa-m theresa-m force-pushed the findclass_cache_fix_0.48 branch from f2bc9ac to 8936149 Compare September 19, 2024 20:42
@theresa-m theresa-m changed the title (0.48) Declare variables first in romToRam entry removal (0.48) romToRam cache follow up Sep 19, 2024
@keithc-ca
Copy link
Contributor

Please update this to mirror the changes in #20196.

@theresa-m theresa-m force-pushed the findclass_cache_fix_0.48 branch from 8936149 to e4a7fd4 Compare September 20, 2024 18:45
@theresa-m theresa-m marked this pull request as ready for review September 20, 2024 18:46
@theresa-m
Copy link
Contributor Author

I just updated the commits to match #20196

@theresa-m
Free romToRam hash table and mutex
1d56245 
Signed-off-by: Theresa Mammarella <[email protected]>
@theresa-m theresa-m force-pushed the findclass_cache_fix_0.48 branch from e4a7fd4 to 1d56245 Compare September 24, 2024 11:15
@theresa-m
Copy link
Contributor Author

This has been updated with the same changes as #20196

@keithc-ca keithc-ca merged commit 97f2682 into eclipse-openj9:v0.48.0-release Sep 24, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@keithc-ca keithc-ca keithc-ca approved these changes

Assignees
No one assigned
Labels
comp:vm
Projects
None yet
Milestone
Release 0.48 (Java 8, 11, 17, 21, 23)...
Development

Successfully merging this pull request may close these issues.
3 participants
@theresa-m @pshipton @keithc-ca