Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x86 assembly source issues with gcc 13 #20278

Merged
merged 1 commit into from
Oct 1, 2024

Conversation

keithc-ca
Copy link
Contributor

  • remove .arch directive
  • add .section .note.GNU-stack,"",@progbits at end of file

Fixes: #20274.

Also tested internally in build 79030.

* remove ".arch" directive
* add .section .note.GNU-stack,"",@progbits at end of file

Signed-off-by: Keith W. Campbell <[email protected]>
@keithc-ca keithc-ca requested a review from pshipton October 1, 2024 20:51
@pshipton pshipton merged commit 79984d0 into eclipse-openj9:master Oct 1, 2024
2 checks passed
@pshipton
Copy link
Member

pshipton commented Oct 1, 2024

If this doesn't cause any issues, we might as well add it to 0.48.

@keithc-ca
Copy link
Contributor Author

If this doesn't cause any issues, we might as well add it to 0.48.

See #20285.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: 64-bit mode not supported on 'pentium4'
2 participants