-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VM snapshot class loader initialization #20863
Fix VM snapshot class loader initialization #20863
Conversation
The code for initializing the persisted applicationClassLoader and extensionClassLoader from a VM snapshot was in an unreachable path. On restore runs, neither of those class loaders will be null, but there was a null check guarding the initialization. This patch reorders some of those checks, and ensures that the class loaders are initialized properly. Signed-off-by: Nathan Henderson <[email protected]>
jenkins test sanity alinux jdk21 |
Expand Error
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Only known failures are seen in the PR builds, which are unrelated to the changes in this PR.
The code for initializing the persisted
applicationClassLoader
andextensionClassLoader
from a VM snapshot was in an unreachable path. On restore runs, neither of those class loaders will benull
, but there was anull
check guarding the initialization.This patch reorders some of those checks, and ensures that the class loaders are initialized properly.
Signed-off-by: Nathan Henderson [email protected]