-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing diagnostics and tuning knobs in inliner #20890
Conversation
e0e22bb
to
3c2d427
Compare
38f3428
to
b7f9403
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Just a couple of minor suggestions.
Signed-off-by: Vijay Sundaresan <[email protected]>
b7f9403
to
78724db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks!
LGTM |
Jenkins test sanity.functional,sanity.openjdk xlinux jdk8,jdk17,jdk23 |
JDK 8 sanity.functional failure appears to be infrastructure-related. Rerunning. . . . Jenkins test sanity.functional xlinux jdk8 |
Jenkins test sanity.functional xlinux jdk8 |
@vijaysun-omr, may I ask you to take a quick look at the failures that occurred in the JDK 23 sanity.openjdk testing? I think it's extremely unlikely that they are related to your changes, but I couldn't find previous examples of those failures. |
I took a quick look at the recent JDK23
|
@a7ehuo, thanks for looking into that! As this seems to be a very safe change, all other testing was successful, and it seems very unlikely that the failure was related to this change, I will go ahead and merge this pull request. |
Several inlining parameters can be tuned via command line options or env vars. Recently, I needed to tune some inlining parameters that could not be controlled without changing the source. This PR fixes the cases that I observed by adding env vars. I also added some heuristic trace diagnostics that print when we estimate a call but don't inline it.