Enable String.indexOf intrinsic for OffHeap on POWER #20930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
luke-li-2003
force-pushed
the
StringIndexOfOffHeapIntrinsic
branch
3 times, most recently
from
f4e69d5 to
d9d0a08
Compare
zl-wang
requested changes
Jan 16, 2025
| TR::MemoryReference::createWithDisplacement( | ||
| cg, array, TR::Compiler->om.offsetOfContiguousDataAddrField(), 8 | ||
| ) | ||
| ); |
There was a problem hiding this comment.
everything looks good, except weird-looking indentations around here and below. is it better to put the first ) after 8 and aligning the second ) with cg/TR? you have the precedence of that already below with addi.
There was a problem hiding this comment.
I have updated the indentations; do they look right now?
Calculate the address for the array data in OffHeap mode correctly for the String.indexOf instrinsic. Signed-off-by: Luke Li <[email protected]>
luke-li-2003
force-pushed
the
StringIndexOfOffHeapIntrinsic
branch
from
d9d0a08 to
8175809
Compare
|
Jenkins test sanity aix,plinux jdk8,jdk23 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Calculate the address for the array data in OffHeap mode correctly for the String.indexOf instrinsic.