Protect entryName from being collected by the GC #20940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j9gc_createJavaLangString can release VM access, which allows the GC to move or collect objects. To prevent this, entryName is pushed to a special frame before the call to j9gc_createJavaLangString. This ensures that entryName is protected from being moved or collected by the GC. Related: eclipse-openj9#20870 Signed-off-by: Babneet Singh <[email protected]>
|
@gacholio Requesting your review. |
gacholio
approved these changes
Jan 16, 2025
|
jenkins test sanity zlinux jdknext |
|
jdknext points to jdk25, which might be more unstable than jdk24. also, starting jdk24 builds. jenkins test sanity amac jdk24 |
|
The failures seen in the PR builds are unrelated to these changes. |
a7ehuo
added a commit
to a7ehuo/openj9
that referenced
this pull request
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
j9gc_createJavaLangStringcan release VM access, which allows the GCto move or collect objects. To prevent this,
entryNameis pushed toa special frame before the call to
j9gc_createJavaLangString. Thisensures that
entryNameis protected from being moved or collected bythe GC.
Related: #20870