-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document the JIT bootstrap process #21003
Conversation
@a7ehuo could you please review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you very much Irwin for documenting the JIT bootstrap process! I just have a few very minor comments
@a7ehuo good for another review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! I just have two minor comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the update! LGTM
@0xdaryl could you review/merge? |
Sorry, this slipped off my radar. I'll review, but I would still appreciate @mpirvu's eyes on this as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me.
Personally I would also want to see a comment on when the compilation threads are stopped and also when does "LIBRARIES_ONUNLOAD" get executed. In all my tests I see only "JVM_EXIT_STAGE"; "LIBRARIES_ONUNLOAD" frees some extra data structure, so would be nice to know how to test that code path.
It's quite a roundabout mechanism for
It seems that if we use the env var to disable FSD, we tell the VM to just unload the JIT. |
[ci-skip] Signed-off-by: Irwin D'Souza <[email protected]>
Docs only change. No need for CI. |
Closes #12506