Add env vars to experiment with large method heuristic #21024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vijaysun-omr
force-pushed
the
large-methods1
branch
from
85f6c08 to
e1e86d0
Compare
The two callers of isLargeCompiledMethod appear to be inconsistent with the "size" that gets passed in. In one case, the size is the estimated call graph size, whereas in the other case, the size is just the bytecode size. This commit changes isLargeCompiledMethod such that the thresholds to compare against are refactored out and passed in from the caller side, thus allowing different thresholds to be used from the two callers. New env vars have been introduced to do some experiments with passing in different size thresholds, though in principle, we could also vary the other thresholds being passed in at each caller. Signed-off-by: Vijay Sundaresan <[email protected]>
vijaysun-omr
force-pushed
the
large-methods1
branch
from
e1e86d0 to
b3b21aa
Compare
|
fyi @mpirvu |
mpirvu
reviewed
Jan 27, 2025
|
No advantage as things stand. I was considering leaving those values to be read from inside the routine as you suggest, but pulled them out in case we wanted to change those values at each caller as well in the future. But I can move it back inside the routine if you prefer. |
|
jenkins test sanity all jdk21 |
vijaysun-omr
changed the title
|
There is a single failure on AIX, |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The two callers of
isLargeCompiledMethodappear to be inconsistent with the "size" that gets passed in. In one case, the size is the estimated call graph size, whereas in the other case, the size is just the bytecode size. This commit changesisLargeCompiledMethodsuch that the thresholds to compare against are refactored out and passed in from the caller side, thus allowing different thresholds to be used from the two callers. New env vars have been introduced to do some experiments with passing in different size thresholds, though in principle, we could also vary the other thresholds being passed in at each caller.