Track JIT body invalidation reasons as bit flags #21050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...and specify the reason whenever we invalidate a JIT body. Post-restore exclusion was already specially distinguished by a flag in TR_PersistentMethodInfo. Preexistence invalidation should also have been similarly distinguished, but the logic to avoid making new preexistence assumptions has been treating all invalidations as potentially preexistence-related. This change is in preparation to add a new invalidation reason: the unloading of an inlined method. It will be important to know when a method has had a JIT body invalidated due to unloading so that when recompiling, inlining can be restricted to avoid repeated invalidation.
|
This will need a coordinated merge with eclipse-omr/omr#7635 |
|
@dsouzai, could you please review? |
dsouzai
reviewed
Feb 3, 2025
dsouzai
approved these changes
Feb 3, 2025
|
jenkins test sanity.functional all jdk8,jdk21 depends eclipse-omr/omr#7635 |
|
the windows builds have two errors; the first is which looks to be #19678. The other seems to be an infra issue: |
|
Will wait until https://openj9-jenkins.osuosl.org/job/Pipeline-OMR-Acceptance/824/ competes before initiating the coordinated merge. |
|
I've promoted the OMR change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and specify the reason whenever we invalidate a JIT body.
Post-restore exclusion was already specially distinguished by a flag in
TR_PersistentMethodInfo.Preexistence invalidation should also have been similarly distinguished, but the logic to avoid making new preexistence assumptions has been treating all invalidations as potentially preexistence-related.
This change is in preparation to add a new invalidation reason: the unloading of an inlined method. It will be important to know when a method has had a JIT body invalidated due to unloading so that when recompiling, inlining can be restricted to avoid repeated invalidation.