Vectorize Vector API intrisics if operands are known #21052
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
gita-omr
commented
Feb 1, 2025
gita-omr
commented
- check if any of operands have known vector type
- vectorize if such operand is found
- check if any of operands have known vector type - vectorize if such operand is found
knn-k
reviewed
Feb 3, 2025
- check if any of operands have known vector type - vectorize if such operand is found
|
Addressed all comments above. |
|
Jenkins test sanity xlinux jdk21 |
|
@vijaysun-omr Do you have any comments? |
knn-k
approved these changes
Feb 4, 2025
|
I will review this in the next couple of days, even though this was merged, and if I have comments, I will share |
vijaysun-omr
reviewed
Feb 5, 2025
| TR::MethodSymbol * methodSymbol = node->getSymbolReference()->getSymbol()->castToMethodSymbol(); | ||
| if (isVectorAPIMethod(methodSymbol)) | ||
| { | ||
| if (methodSymbol->getRecognizedMethod() == TR::jdk_internal_vm_vector_VectorSupport_compare) |
There was a problem hiding this comment.
Just curious, is this transformation based on knowledge about the operands also applicable to other vector API methods apart from the compare method for which it seems to be applied here ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.