-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JFR can invoke VM.setJFRRecordingFileName() before VM.startJFR() #21070
Conversation
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Outdated
Show resolved
Hide resolved
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Show resolved
Hide resolved
Allow VM.setJFRRecordingFileName() to be invoked before VM.startJFR(); Ignore the recording filename changing within the commands JFR.dump and JFR.stop commands. Signed-off-by: Jason Feng <[email protected]>
jenkins test sanity.functional alinux64 jdk21 |
jcl/src/java.base/share/classes/openj9/internal/tools/attach/target/DiagnosticUtils.java
Show resolved
Hide resolved
A known issue |
jenkins test sanity.functional alinux64 jdk21 |
jenkins test sanity.functional xlinux jdk11 |
if ((defaultFileNameLen != strlen(jfrFileName)) | ||
|| (0 != strncmp(DEFAULT_JFR_FILE_NAME, jfrFileName, defaultFileNameLen)) | ||
) { | ||
PORT_ACCESS_FROM_JAVAVM(vm); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It isn't new with this change, but I notice that this leaks the old filename if called with an equal name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ill address this
JFR can invoke
VM.setJFRRecordingFileName()
beforeVM.startJFR()
Allow
VM.setJFRRecordingFileName()
to be invoked beforeVM.startJFR()
;Ignore the changing of the recording filename within the commands
JFR.dump
andJFR.stop
.Related to
Signed-off-by: Jason Feng [email protected]