Handle frame-skipping of jvmtiGetFrameLocation in frame callback #21084
+34
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Personal builds: https://hyc-runtimes-jenkins.swg-devops.com/job/Pipeline-Build-Test-Personal/26244/ https://hyc-runtimes-jenkins.swg-devops.com/view/OpenJ9%20-%20Personal/job/Pipeline-Build-Test-Personal/26228/ |
|
@babsingh Can you please take a look? |
babsingh
reviewed
Feb 7, 2025
|
@gacholio can you also review these changes? |
thallium
force-pushed
the
skip-count-fix
branch
from
19e1ac9 to
0a41d9e
Compare
babsingh
approved these changes
Feb 7, 2025
|
I see you are still setting skipCount which seems inappropriate. |
thallium
force-pushed
the
skip-count-fix
branch
from
0a41d9e to
51bb11e
Compare
|
Got rid of skipCount for all versions. |
|
@gacholio can you take another look? |
|
Will do. |
gacholio
reviewed
Feb 12, 2025
gacholio
reviewed
Feb 14, 2025
thallium
force-pushed
the
skip-count-fix
branch
from
51bb11e to
362167e
Compare
gacholio
reviewed
Feb 14, 2025
Since frame callback is not called for skipped frame, frames with JvmtiMountTransition annotation will not be correctly handled. Signed-off-by: Gengchen Tuo <[email protected]>
Signed-off-by: Gengchen Tuo <[email protected]>
thallium
force-pushed
the
skip-count-fix
branch
from
362167e to
044dc7e
Compare
gacholio
approved these changes
Feb 14, 2025
|
jenkins test sanity zlinux jdk21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since frame callback is not called for skipped frame, frames with JvmtiMountTransition annotation will not be correctly handled.
Also added JvmtiMountTransition annotations to
Continuation.enter(),Continuation.yield(), andContinuation.yield0().Fixes: #20541