Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

x86: Implement fma intrinsic #21118

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

x86: Implement fma intrinsic #21118

wants to merge 1 commit into from
+165 −0

Conversation

BradleyWood
Copy link
Member

@BradleyWood BradleyWood commented Feb 12, 2025 •
edited
Loading

This PR implements Math.fma intrinsics on x86 with vfmadd instructions.

Issue: #7474

@BradleyWood
Copy link
Member Author

Requires fma, extensions.

Here are performance numbers,

Benchmark Compared to Baseline Compared to Hotspot
FMABench.benchFloatFMA 552x 1.19x
FMABench.benchDoubleFMA 1482x 1.16x

@BradleyWood BradleyWood force-pushed the fma branch 3 times, most recently from 05da435 to ff7bb16 Compare February 12, 2025 06:31
@BradleyWood
x86: Implement fma intrinsic
229e619 
Signed-off-by: Bradley Wood <[email protected]>
@BradleyWood
Copy link
Member Author

FYI @0xdaryl, @JamesKingdon

@hzongaro Would you mind reviewing?

@JamesKingdon
Copy link
Contributor

Thanks Brad, what a result!

@hzongaro hzongaro self-requested a review February 12, 2025 15:48
@hzongaro hzongaro self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hzongaro hzongaro Awaiting requested review from hzongaro

Assignees

@hzongaro hzongaro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BradleyWood @JamesKingdon @hzongaro