Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ds/org.eclipse.pde.ds.annotations #1645

Merged
merged 2 commits into from
Mar 6, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 3bff8a8443fc12128b016ab9ebf3e5c7ee104eab Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Thu, 6 Mar 2025 02:46:09 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
index e20f546b1b..3398e73071 100644
--- a/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.annotations/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %Bundle-Name
 Bundle-SymbolicName: org.eclipse.pde.ds.annotations;singleton:=true
-Bundle-Version: 1.4.0.qualifier
+Bundle-Version: 1.4.100.qualifier
 Bundle-Activator: org.eclipse.pde.ds.internal.annotations.Activator
 Bundle-Vendor: %Bundle-Vendor
 Require-Bundle: org.eclipse.ui;bundle-version="[3.105.0,4.0.0)",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   285 files     285 suites   46m 16s ⏱️
 3 608 tests  3 532 ✅  76 💤 0 ❌
11 016 runs  10 785 ✅ 231 💤 0 ❌

Results for commit d21b01c.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ds/org.eclipse.pde.ds.annotations branch from 7c0e15e to d21b01c Compare March 6, 2025 13:39
@laeubi laeubi merged commit 952bddd into master Mar 6, 2025
18 checks passed
@akurtakov akurtakov deleted the clean-code/ds/org.eclipse.pde.ds.annotations branch March 6, 2025 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants