Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ds/org.eclipse.pde.ds.core #1646

Merged
merged 2 commits into from
Mar 7, 2025

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

@eclipse-pde-bot
Copy link
Contributor Author

eclipse-pde-bot commented Mar 6, 2025

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From b5f5b971a87d8e71418b6d16675c59d6f68b8dde Mon Sep 17 00:00:00 2001
From: Eclipse PDE Bot <[email protected]>
Date: Fri, 7 Mar 2025 02:48:22 +0000
Subject: [PATCH] Version bump(s) for 4.36 stream


diff --git a/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF b/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF
index 3a0752f8c1..c31b201724 100644
--- a/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF
+++ b/ds/org.eclipse.pde.ds.core/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.pde.ds.core;singleton:=true
-Bundle-Version: 1.3.700.qualifier
+Bundle-Version: 1.3.800.qualifier
 Bundle-Activator: org.eclipse.pde.internal.ds.core.Activator
 Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
  org.eclipse.core.filebuffers;bundle-version="[3.3.0,4.0.0)",
-- 
2.48.1

Further information are available in Common Build Issues - Missing version increments.

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   279 files   -   6     279 suites   - 6   48m 48s ⏱️ + 1m 47s
 3 608 tests ±  0   3 531 ✅ ±  0   76 💤 ± 0  1 ❌ ±0 
10 822 runs   - 194  10 619 ✅  - 165  202 💤  - 29  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 02356c1. ± Comparison against base commit 4e00417.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ds/org.eclipse.pde.ds.core branch from ce8cf29 to 5fbd4db Compare March 6, 2025 13:39
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ds/org.eclipse.pde.ds.core branch from 5fbd4db to caacd6e Compare March 7, 2025 02:42
@laeubi laeubi merged commit c7d99fd into master Mar 7, 2025
16 of 18 checks passed
@akurtakov akurtakov deleted the clean-code/ds/org.eclipse.pde.ds.core branch March 7, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants