Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ui/org.eclipse.pde.genericeditor.extension.tests #1653

Merged
merged 2 commits into from
Mar 7, 2025
Merged

Clean Code for ui/org.eclipse.pde.genericeditor.extension.tests #1653

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cf93084
Perform clean code of ui/org.eclipse.pde.genericeditor.extension.tests
eclipse-pde-bot Mar 7, 2025
457a4aa
Version bump(s) for 4.36 stream
eclipse-pde-bot Mar 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ui/org.eclipse.pde.genericeditor.extension.tests/META-INF/MANIFEST.MF
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ Manifest-Version: 1.0
Bundle-ManifestVersion: 2
Bundle-Name: Tests for Generic Target Platform Editor
Bundle-SymbolicName: org.eclipse.pde.genericeditor.extension.tests
Bundle-Version: 1.3.0.qualifier
Bundle-Version: 1.3.100.qualifier
Bundle-Vendor: Eclipse.org
Bundle-RequiredExecutionEnvironment: JavaSE-21
Require-Bundle: org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
Expand Down
2 changes: 1 addition & 1 deletion ui/org.eclipse.pde.genericeditor.extension.tests/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<relativePath>../../</relativePath>
</parent>
<artifactId>org.eclipse.pde.genericeditor.extension.tests</artifactId>
<version>1.3.0-SNAPSHOT</version>
<version>1.3.100-SNAPSHOT</version>
<packaging>eclipse-test-plugin</packaging>

<properties>
Expand Down
6 changes: 4 additions & 2 deletions ...tests/src/org/eclipse/pde/genericeditor/extension/tests/AttributeNameCompletionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,9 @@ public void testAttributeNameSuggestions() throws Exception {
while (offset < text.length()) {
int nextSpace = text.indexOf(' ', offset) + 1;
int nextOpen = text.indexOf('<', offset);
if (nextSpace == 0 && nextOpen == -1)
if (nextSpace == 0 && nextOpen == -1) {
break;
}
if (nextSpace == 0) {
offset = nextOpen;
} else if (nextOpen == -1) {
Expand Down Expand Up @@ -75,8 +76,9 @@ public void testNoAttributeNameRepeatSuggestions() throws Exception {
while (offset < text.length()) {
int nextSpace = text.indexOf(" ", offset) + 1;
int nextOpen = text.indexOf('<', offset);
if (nextSpace == 0 && nextOpen == -1)
if (nextSpace == 0 && nextOpen == -1) {
break;
}
if (nextSpace == 0) {
offset = nextOpen;
} else if (nextOpen == -1) {
Expand Down
3 changes: 2 additions & 1 deletion ...sion.tests/src/org/eclipse/pde/genericeditor/extension/tests/TagValueCompletionTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,9 @@ public void testAttributeNameSuggestions() throws Exception {
while (offset < text.length()) {
int nextClose = text.indexOf('>', offset);
int nextNewLine = text.indexOf('\n', offset);
if (nextClose == 0 && nextNewLine == -1)
if (nextClose == 0 && nextNewLine == -1) {
break;
}
if (nextClose == 0) {
offset = nextNewLine;
} else if (nextNewLine == -1) {
Expand Down
Loading