Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean Code for ui/org.eclipse.pde.ui #1663

Merged
merged 1 commit into from
Mar 11, 2025
Merged

Conversation

eclipse-pde-bot
Copy link
Contributor

The following cleanups where applied:

  • Add final modifier to private fields
  • Add missing '@Deprecated' annotations
  • Add missing '@Override' annotations
  • Add missing '@Override' annotations to implementations of interface methods
  • Convert control statement bodies to block
  • Make inner classes static where possible
  • Replace deprecated calls with inlined content where possible

Copy link

github-actions bot commented Mar 6, 2025

Test Results

   279 files   -   6     279 suites   - 6   47m 43s ⏱️ + 1m 36s
 3 608 tests ±  0   3 531 ✅  -   1   76 💤 ± 0  1 ❌ +1 
10 822 runs   - 194  10 620 ✅  - 165  201 💤  - 30  1 ❌ +1 

For more details on these failures, see this check.

Results for commit 389467e. ± Comparison against base commit 3e1aead.

♻️ This comment has been updated with latest results.

@laeubi laeubi force-pushed the clean-code/ui/org.eclipse.pde.ui branch from 91b8ba7 to 1c2e599 Compare March 6, 2025 15:00
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.ui branch from 1c2e599 to 3166025 Compare March 7, 2025 03:29
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.ui branch 2 times, most recently from 77c243f to 35cb894 Compare March 9, 2025 03:07
@eclipse-pde-bot eclipse-pde-bot force-pushed the clean-code/ui/org.eclipse.pde.ui branch from 35cb894 to 389467e Compare March 10, 2025 03:09
Copy link
Contributor

@laeubi laeubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only deprecation warnings

@laeubi laeubi merged commit 338779a into master Mar 11, 2025
13 of 18 checks passed
@akurtakov akurtakov deleted the clean-code/ui/org.eclipse.pde.ui branch March 11, 2025 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants