Wrap viewer in CheckboxTablePart within a FilteredTable #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptziegler
commented
Mar 7, 2025
Comment on lines
+74
to
+82
| @Override | ||
| protected void preservingSelection(Runnable updateCode) { | ||
| super.preservingSelection(updateCode); | ||
| // The super class implementation will preserve a root element's check | ||
| // mark but that can cause newly unfiltered children to become check | ||
| // marked. | ||
| // See https://github.com/eclipse-pde/eclipse.pde/issues/62 | ||
| restoreCachedState(); | ||
| } |
There was a problem hiding this comment.
In hindsight, I'm not really sure if this is really needed. There aren't multiple levels of children, so this issue probably can't happen here.
ptziegler
commented
Mar 7, 2025
Comment on lines
+123
to
+130
| <resource path="src/org/eclipse/pde/internal/ui/shared/CachedCheckboxTableViewer.java" type="org.eclipse.pde.internal.ui.shared.CachedCheckboxTableViewer"> | ||
| <filter comment="Extends CheckboxTableViewer to match CachedCheckboxTreeviewer" id="571473929"> | ||
| <message_arguments> | ||
| <message_argument value="CheckboxTableViewer"/> | ||
| <message_argument value="CachedCheckboxTableViewer"/> | ||
| </message_arguments> | ||
| </filter> | ||
| </resource> |
There was a problem hiding this comment.
I'm not sure whether inheritance is better than composition. But otherwise it's not possible to respond to e.g. calling setAllChecked() on the viewer.
|
And a side-by-side comparison of the Plugin table, which has been migrated from a tree- to a table viewer, as well as one of the tables for which the quick-filter is added due to the FilteredTable.
|
By using the FilteredTable, we get a quick-filter for all extending parts for free. This includes: - The Cross-platform page of the "Deployable features" export wizard. - The Update Java Classpath page of the "Update classpath..." action - The Selection page of the "Import Plug-ins and Fragments" wizard - The Update Java Classpath page of the "Plug-in from Existing JAR Archives" wizard. - The Template Selection page of the "Plug-in Project" page. Together with the quick-filter comes a caching of the checked table items. Those elements remain checked, even if currently hidden by the filter and will be restored once they become visible again. Furthermore, the PluginListPage has been adapted to use a CheckboxTablePart rather than a CheckboxTreePart (effectively reverting 4c1edad), to match the list of plugins that it displays. Contributes to eclipse-pde#1497
ptziegler
force-pushed
the
use-filtered-table
branch
from
12ec3ef to
54ce71c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By using the FilteredTable, we get a quick-filter for all extending parts for free. This includes:
Together with the quick-filter comes a caching of the checked table items. Those elements remain checked, even if currently hidden by the filter and will be restored once they become visible again.
Furthermore, the PluginListPage has been adapted to use a CheckboxTablePart rather than a CheckboxTreePart (effectively reverting 4c1edad), to match the list of plugins that it displays.
Contributes to #1497